Update to latest commit of argo-rollouts-manager '4619e3168941619f554e3f987ad440589838c7a3' #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgwest
force-pushed
the
upgrade-rollouts-manager
branch
from
1611bce to
d788912
Compare
…e3f987ad440589838c7a3' Signed-off-by: Jonathan West <jonwest@redhat.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
jgwest
force-pushed
the
upgrade-rollouts-manager
branch
from
d788912 to
9d65e90
Compare
Signed-off-by: Jonathan West <jonwest@redhat.com>
jgwest
force-pushed
the
upgrade-rollouts-manager
branch
from
23a205f to
a8dd2bf
Compare
Member
Author
|
/retest |
jgwest
commented
Nov 4, 2025
| @@ -1,4 +1,4 @@ | |||
| package sequential | |||
| package parallel | |||
Member
Author
There was a problem hiding this comment.
I moved some tests from sequential to parallel, in order to reduce the amount of time it takes the sequential E2E tests to run.
I have verified that all of these tests are 'safe' to run in parallel
jgwest
commented
Nov 4, 2025
| // - I'm not aware of a way to detect when this has completed, so instead I am inserting a 15 second pause. | ||
| // - If anyone has a better way of doing this, let us know. | ||
| // time.Sleep(15 * time.Second) | ||
| // TODO: Uncomment this once the sequential test suite timeout has increased. |
Member
Author
There was a problem hiding this comment.
I will uncomment this on another PR when we increase the sequential test timeout
jgwest
commented
Nov 4, 2025
|
|
||
|
|
||
|
|
||
|
|
Member
Author
There was a problem hiding this comment.
Extra spaces will be automatically removed next time upgrade-rollouts-manager runs
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jannfis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
openshift-merge-bot
bot
merged commit 35d543b
into
redhat-developer:master
16 checks passed
Naveena-058
pushed a commit
to Naveena-058/nas-gitops-operator
that referenced
this pull request
Nov 6, 2025
…e3f987ad440589838c7a3' (redhat-developer#994) * Update to latest commit of argo-rollouts-manager '4619e3168941619f554e3f987ad440589838c7a3' Signed-off-by: Jonathan West <jonwest@redhat.com> * Log additional debug logs on failure of 1-040 Signed-off-by: Jonathan West <jonwest@redhat.com> * chore: Move parallelizable tests to parallel Signed-off-by: Jonathan West <jonwest@redhat.com> * chore: increase Ginkgo sequential timeout slightly: Signed-off-by: Jonathan West <jonwest@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: NAVEENA S <nas@redhat.com>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
…mat (#997) * Update to latest commit of argo-rollouts-manager '4619e3168941619f554e3f987ad440589838c7a3' (#994) * Update to latest commit of argo-rollouts-manager '4619e3168941619f554e3f987ad440589838c7a3' Signed-off-by: Jonathan West <jonwest@redhat.com> * Log additional debug logs on failure of 1-040 Signed-off-by: Jonathan West <jonwest@redhat.com> * chore: Move parallelizable tests to parallel Signed-off-by: Jonathan West <jonwest@redhat.com> * chore: increase Ginkgo sequential timeout slightly: Signed-off-by: Jonathan West <jonwest@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: NAVEENA S <nas@redhat.com> * Convert Kuttl test 1-098_validate_dex_clientsecret to Ginkgo test format Signed-off-by: NAVEENA S <nas@redhat.com> --------- Signed-off-by: Jonathan West <jonwest@redhat.com> Signed-off-by: NAVEENA S <nas@redhat.com> Co-authored-by: Jonathan West <jgwest@users.noreply.github.com> Co-authored-by: NAVEENA S <nas@redhat.com> Co-authored-by: Siddhesh Ghadi <61187612+svghadi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to most recent 'argo-rollouts-manager' commit: argoproj-labs/argo-rollouts-manager@4619e31
I had to make some additional changes to E2E test as the sequential E2E tests were timing out. I have reached out to our team to increase the timoeout, but in the mean time I have moved some sequential tests to parallel.